fix module cache breaking for modules not being mocked #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Jul 13, 2022
|
|
||
| return [...global.__quibble.quibbledModules.entries()].find(([m]) => m === moduleFilepath) | ||
| const stub = global.__quibble.quibbledModules.get(moduleFilepath) | ||
| return stub ? [moduleFilepath, stub] : undefined |
There was a problem hiding this comment.
drive-by performance improvement
There was a problem hiding this comment.
always appreciated. this lib doesn't get a lot of love
|
Hand-merged this one after confirming locally b/c CI was disconnected. Thanks! Landed in 0.6.10 |
This was referenced Jul 14, 2022
|
This was reverted in 0.6.11. See discussion in testdouble/testdouble.js#493 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves testdouble/testdouble.js#492 without breaking any existing tests.
Confirmed this work great in our usage of testdouble in Lighthouse tests