Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usage of global with globalThis for better browser support #508

Merged
merged 6 commits into from Mar 13, 2023

Conversation

maxbeatty
Copy link
Contributor

I ran into the same issue as #438 and #471 but the workarounds didn't work. Our stack is TypeScript + esbuild + Karma + mocha (and hopefully testdouble 😀 ). Our library is completely browser-based so we only want to test in real browsers.

These changes are largely the same as #472 but also upgrades the supported node engine as mentioned in #471 (comment) . Node.js Release Schedule

"node": ">= 4.0.0"
"node": ">= 14"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Literally laughed out loud at this. Good catch

@searls searls merged commit 6a9ec89 into testdouble:main Mar 13, 2023
4 checks passed
@searls
Copy link
Member

searls commented Mar 13, 2023

Great patch, thank you! Landed in v3.17.0

@maxbeatty maxbeatty deleted the browser-global branch March 13, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants