New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replaceEsm not working on windows #491
Comments
Paging @giltayar if he might have any insight 🙏 |
I made the following change inside quibble, which resolved the bug:
Of course, I shouldn't be hardcoding the drive there. But anyway, the real fix is probably something to do with correctly juggling the format of the Error filename / module name / URLs being passed around, being mindful of Windows's differing slashes / existence of a drive suffix. |
Thanks for digging into this. Ultimately, if you (or another developer that uses Windows) might consider sending a PR with a test for this that they can assert works OK on windows without breaking anything else, I'd be eager to accept it. |
Cloned your repo, updated testdouble to the latest version, and added an |
Description
ES modules are not mocked on windows. Works fine on Mac.
Environment
node -v
output: 14.8.2yarn --version
output: 1.22.19npm ls testdouble
(oryarn list testdouble
) version: 3.16.15Example Repo
https://github.com/connorjclark/testdouble-win-example
node --loader=testdouble main.js
printsoriginal
on windows,replaced
on Mac.The text was updated successfully, but these errors were encountered: