Add thenReturn to PromiseStubber type declaration
#481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@billtong would be great if you can check if it works for your use case, for mine it is good (I think we have the exact same situation) |
|
I will add some tests |
johnbotris
force-pushed
the
promise-stubber-then-return
branch
from
2a1fdd3
to
4894b46
Compare
This allows you to stub an async function with a sequence of promises that may either resolve or reject
To ensure that `PromiseStubber.thenReturn` will compile
johnbotris
force-pushed
the
promise-stubber-then-return
branch
from
4894b46
to
81af4df
Compare
|
Let me know when you think this is ready for review |
|
@johnbotris I just test my code with your commits. it's working great. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to stub an async function with a sequence of promises that may either resolve or reject.
It will also not allow you to provide non-promise values when stubbing async functions (which is good)
closed #478